Added staticfiles panel class. #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a screenshot: |
|
👍 |
| from django.contrib.staticfiles.templatetags import staticfiles | ||
|
|
||
| from django.utils.translation import ungettext, ugettext_lazy as _ | ||
| from django.utils.datastructures import SortedDict |
There was a problem hiding this comment.
Future-proof version:
try:
from collections import OrderedDict
except ImportError:
from django.utils.datastructures import SortedDict as OrderedDict
Both versions currently exist in the code base :-/
- adds some docstrings - adds some basic tests - adds the staticfiles panel to the default list of panels - fixed a pluralization bug in the template - refactored some things into own methods for easier testing
…level monkey patching.
|
Frankly I don't know why that one test fails on Travis, it works locally with Tox. |
|
Unfortunately that matches my experience with Travis :( |
|
I wonder if it's somehow related to the test environments running side by side? In other words, is this an indicator for the code not being threadsafe? |
|
The diff looks pretty good, my feedback would be in the realm of "keep deps sorted alphabetically". So, assuming |
aaugustin
added a commit
that referenced
this pull request
Dec 14, 2013
Added staticfiles panel class.
ryneeverett
pushed a commit
to ryneeverett/django-debug-toolbar
that referenced
this pull request
Oct 2, 2016
…cfiles Added staticfiles panel class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick dump of my current WIP, @aaugustin. Tests and docs are missing but I'll work on them this week before we do a final release.